On my bike, an '89 ETZ 251, I've had some charging issues, in that it didn't.
I normally ride with the headlight on, a H4 55/60W unit, and problems first became apparent by the engine cutting out. Switching the lights off made it run again, but getting closer to home it also cut out on the indicator light. When I came home, the battery was almost flat & measuring the voltage indicated it didn't charge, not at all. This had happened before, and then I had traced it back to a faulty connection inside the original mechanical voltage regulator.
Measuring on the regulator (see Fig. 6.3 in the Haynes manual), I had 14.3V from the rectifier, on pole D+, while pole 51 (which connects to the battery, un-fused) reads the much lower battery voltage. After I took off the regulator's cap, and sure enough, that same connection again had free play:
Measuring while pushing the wire into the connection gives 14.3V, also on pole 51.
I had soldered this connection before, but I cannot solder it properly, as I cannot get it warm enough: the pole drains too much heat from my soldering iron. Last time I soldered it, it kept for the summer. Maybe if I take the regulator off the bike, shield parts & use a flame it could work, but I haven't done that. Shielding the rest properly from a flame seems difficult.
Instead, after isolating the battery, I wound some copper wire around the coil end, and knotted that to the pole. Thereafter covered the lot as good as I could with fresh solder. It does make an electrical connection, but it hasn't flowed well.
Anyway, I think the real problem is not in the soldering, but rather that the heavy coil is being fixated by that soldered connection. And that the coil vibrates. So I fixated the coil, at the other side, with some epoxy clay:
Hope it keeps a bit longer now.
It's obviously an age problem, but I like this mechanical regulator. Hopefully this is of use to someone, once.